This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Greptile Summary

This PR adds metadata.namespace to all namespace-scoped Helm chart resources (Deployments, DaemonSets, Services, ServiceAccounts, ConfigMaps, Ingress, and HTTPRoute) across the topograph chart and its two sub-charts, addressing issue #344 where resources could be placed in the wrong namespace.

• Conditional guard is non-standard: Every template uses {{- if ne .Release.Namespace \"default\" }} to skip emitting the namespace for the default namespace. The Helm-recommended pattern is an unconditional namespace: {{ .Release.Namespace }}; omitting the field for default means GitOps tools can misplace resources when the cluster context's default namespace differs.
• Test Pod templates overlooked: templates/tests/test-healthz.yaml and templates/tests/test-metrics.yaml are namespace-scoped Pod resources that were not updated, leaving them inconsistent with the rest of the fix.
• RBAC and ServiceMonitor are intentionally unchanged: ClusterRole/ClusterRoleBinding are cluster-scoped (no namespace needed on metadata), and ServiceMonitor uses a dedicated .Values.serviceMonitor.namespace value — both are correctly left untouched.

Confidence Score: 3/5

The change correctly addresses namespace placement for non-default namespaces but leaves a gap for resources deployed to default and omits the test Pod templates entirely.

All 11 templates use a conditional that skips the namespace field when deploying to the default namespace. Rendered manifests from helm template or a GitOps pipeline have no explicit namespace for that case, and the cluster's contextual default — which may differ — will be used instead. Additionally, two namespace-scoped test Pod templates were not updated, keeping them inconsistent with the rest of the fix. Both gaps could reproduce the original misplacement bug in specific deployment patterns.

All 11 changed templates share the same conditional guard pattern; charts/topograph/templates/tests/test-healthz.yaml and test-metrics.yaml were not updated and still lack a namespace field.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[helm install / helm template] --> B{Release.Namespace}
    B -->|"== 'default'"| C[Namespace field OMITTED from manifest]
    B -->|"!= 'default'"| D[namespace: Release.Namespace emitted]
    C --> E{Applied by?}
    E -->|"helm install --namespace default"| F[Helm API call sets namespace ✓]
    E -->|"kubectl apply / GitOps tool"| G[kubectl context default namespace used ⚠️]
    D --> H[Resource lands in correct namespace ✓]
    G --> I{Context namespace == default?}
    I -->|Yes| J[Correct namespace ✓]
    I -->|No| K[Wrong namespace — issue #344 still present ✗]

_{Reviews (1): Last reviewed commit: "added namespace to topograph node-data-b..." | Re-trigger Greptile}